Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(queuing)!: build executable server-side implementation #927

Merged
merged 22 commits into from
Aug 23, 2023
Merged

feat(queuing)!: build executable server-side implementation #927

merged 22 commits into from
Aug 23, 2023

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Aug 9, 2023

Part of the work for go-vela/community#805

  • Creates new BuildExecutable database table with add / pop functionality.
  • Update PublishToQueue to only include non-sensitive information
  • Add API endpoint for requesting a build executable put behind a MustBuildAccess perm check

@ecrupper ecrupper requested a review from a team as a code owner August 9, 2023 16:03
@ecrupper ecrupper self-assigned this Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023 •
edited
Loading

Codecov Report

Merging #927 (b196845) into main (ee0d2a0) will decrease coverage by 0.19%.
The diff coverage is 59.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #927      +/-   ##
==========================================
- Coverage   71.11%   70.92%   -0.19%     
==========================================
  Files         304      310       +6     
  Lines       12527    12740     +213     
==========================================
+ Hits         8908     9036     +128     
- Misses       3177     3250      +73     
- Partials      442      454      +12
Files Changed Coverage Δ
api/build/executable.go 0.00% <0.00%> (ø)
api/build/publish.go 0.00% <0.00%> (ø)
database/database.go 63.38% <ø> (ø)
database/executable/executable.go 56.00% <56.00%> (ø)
database/executable/pop.go 68.08% <68.08%> (ø)
database/executable/create.go 68.96% <68.96%> (ø)
database/resource.go 70.53% <70.00%> (-0.06%) ⬇️
database/executable/opts.go 100.00% <100.00%> (ø)
database/executable/table.go 100.00% <100.00%> (ø)

@ecrupper ecrupper mentioned this pull request Aug 21, 2023
Merged
plyr4
plyr4 reviewed Aug 23, 2023
View reviewed changes
database/executable/opts.go Outdated Show resolved Hide resolved
@ecrupper ecrupper merged commit 6874831 into main Aug 23, 2023
12 of 13 checks passed
@ecrupper ecrupper deleted the pipeline-build-table branch August 23, 2023 15:32
@ecrupper ecrupper mentioned this pull request Aug 23, 2023
Merged
@colindean colindean mentioned this pull request Aug 28, 2023
Closed
@ecrupper ecrupper mentioned this pull request Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@timhuynh94 timhuynh94 timhuynh94 approved these changes

@plyr4 plyr4 plyr4 approved these changes

Assignees

@ecrupper ecrupper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ecrupper @timhuynh94 @plyr4 @wass3r